Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version gem dependency #22

Merged
merged 2 commits into from
Jan 6, 2012
Merged

Remove version gem dependency #22

merged 2 commits into from
Jan 6, 2012

Conversation

rymai
Copy link
Member

@rymai rymai commented Jan 5, 2012

Hi Michael,

I have conflicts in our Rails app between the paper_trail gem and the version gem since both declare a Version class and the version gem overwrite the []= method... But since the version gem can be replaced by RubyGem's methods, I thought it would the opportunity to solve my issues and to remove a not-so-useful dependency.

What do you think, do you see any downside (for instance the dependency on RubyGem)?

@netzpirat netzpirat merged commit 19af21a into guard:master Jan 6, 2012
@netzpirat
Copy link
Contributor

You're the best! That was exactly the next item on my to-do list. I put it on the list after I saw how you solved the same problem in guard-rspec. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants