Fix typo in README #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot! I totally missed it... |
|
Your Gist looks really great and I think it would be a great addition to Guard::Jasmine for better Rails 2/3 support. I guess I'll incorporate it next week into Guard::Jasmine <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the "A note on Rails 2 and 3" section, the example Guardfile should use
:jasmine_urlinstead of:url- fix attached.Thanks for the great guard script!
I also run the jasmine server from Guard in Rails 3.0 - not sure if that would be interesting to include into the README, or if you're favoring only 3.1. There's a slight hitch, since Guard doesn't guarantee that one guard process starts before another, so I have to make guard-jasmine wait until the jasmine server starts. Gist here https://gist.github.com/1224382