Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress Tests failures #424

Closed
Remi-Gau opened this issue May 11, 2023 · 6 comments
Closed

Cypress Tests failures #424

Remi-Gau opened this issue May 11, 2023 · 6 comments

Comments

@Remi-Gau
Copy link
Contributor

It seems that the Cypress tests have been failing for a while on master.

https://github.com/neurobagel/annotation_tool/actions/workflows/main.yml

Did not see any issues about that.

Not seen on any recent PR as they seem to target : dev_components_talk_to_store_directly

@surchs
Copy link
Contributor

surchs commented May 11, 2023

Yeah, I think you uncovered our little secret: these tests are currently expected to fail, but will stop failing once the long-lived refactor branch is finally merged. I think we're very close.

@Remi-Gau
Copy link
Contributor Author

that was really well hidden...

OK so should I hold off to merge all the dependabot PRs on this repo or should I merge them?

@Remi-Gau
Copy link
Contributor Author

I guess can also probably retarget them to a different base branch...

@surchs
Copy link
Contributor

surchs commented May 11, 2023

no, merge them into main and ignore the failing tests, I think. @jarmoza wdyt?

@Remi-Gau
Copy link
Contributor Author

note from today's meeting: let's wait before the refactor is done and merged before merging all of those

@jarmoza
Copy link
Contributor

jarmoza commented Jun 5, 2023

Tests are now passing on master as of #437 and #440

@jarmoza jarmoza closed this as completed Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants