MAINT HonestForestClassifier now has bootstrap=True as the defaul…

…t. And removing old MIGHT code (#274) * Fix honest forest bootstrap option * Cleanup old class-based (CO)MIGHT code * Fix bug in `build_coleman_forest` where covariate_index was not being passed through --------- Signed-off-by: Adam Li <adam2392@gmail.com>
neurodata · Jun 11, 2024 · 3cfb082 · 3cfb082
1 parent e858963
commit 3cfb082
Show file tree

Hide file tree

Showing 19 changed files with 269 additions and 3,627 deletions.
diff --git a/doc/api.rst b/doc/api.rst
@@ -145,10 +145,6 @@ tree models.
 .. autosummary::
    :toctree: generated/
 
-   FeatureImportanceForestRegressor
-   FeatureImportanceForestClassifier
-   PermutationForestClassifier
-   PermutationForestRegressor
    build_coleman_forest
    build_permutation_forest
    build_oob_forest

diff --git a/doc/whats_new/v0.5.rst b/doc/whats_new/v0.5.rst
@@ -26,7 +26,7 @@ Changelog
   handles the case where there is one feature view that is exhausted, and
   another that is not for ``apply_max_features_per_feature_set = False``,
   by `Adam Li`_ (:pr:`#183`).
-- |Fix| :class:`sktree.stats.FeatureImportanceForestClassifier` now correctly passes
+- |Fix| ``sktree.stats.FeatureImportanceForestClassifier`` now correctly passes
   metric kwargs to the null distribution function, by `Adam Li`_ (:pr:`#183`).
 
 Code and Documentation Contributors

diff --git a/doc/whats_new/v0.6.rst b/doc/whats_new/v0.6.rst
@@ -24,7 +24,7 @@ Changelog
   handles the case where there is one feature view that is exhausted, and
   another that is not for ``apply_max_features_per_feature_set = False``,
   by `Adam Li`_ (:pr:`#183`).
-- |Fix| :class:`sktree.stats.FeatureImportanceForestClassifier` now correctly passes
+- |Fix| ``sktree.stats.FeatureImportanceForestClassifier`` now correctly passes
   metric kwargs to the null distribution function, by `Adam Li`_ (:pr:`#183`).
 - |Enhancement| :func:`sktree.datasets.make_trunk_classification` now
   has a generative model based on Trunk and banded covariance, :func:`sktree.datasets.approximate_clf_mutual_information` and

diff --git a/doc/whats_new/v0.8.rst b/doc/whats_new/v0.8.rst
@@ -21,6 +21,10 @@ Changelog
 - |Feature| Simulations in ``sktree.datasets.hyppo`` now throw a warning instead
     of an error when the number of samples is less than the number of dimensions.
     By `Sambit Panda`_ (:pr:`#279`)
+- |API| :class:`sktree.HonestForestClassifier` now has ``bootstrap=True`` as the default
+    argument. By `Adam Li`_ (:pr:`#274`)
+- |API| Removed all instances of ``FeatureImportanceForestClassifier`` and outdated
+    MIGHT code. By `Adam Li`_ (:pr:`#274`)
 
 Code and Documentation Contributors
 -----------------------------------

diff --git a/examples/hypothesis_testing/README.txt b/examples/hypothesis_testing/README.txt
diff --git a/examples/hypothesis_testing/plot_MI_genuine_hypothesis_testing_forest.py b/examples/hypothesis_testing/plot_MI_genuine_hypothesis_testing_forest.py