Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quadratic simulation loses power supposedly when using sklearn-fork DecisionTree vs sklearn DecisionTree #171

Open
adam2392 opened this issue Nov 14, 2023 · 1 comment
Open

Quadratic simulation loses power supposedly when using sklearn-fork DecisionTree vs sklearn DecisionTree #171

adam2392 opened this issue Nov 14, 2023 · 1 comment

Comments

@adam2392
Copy link
Collaborator

First reported by @sampan501

We then added the following LOC, which we can probably extend further to the "power" setting, where we actually estimate the power and see if the performance still differs: https://github.com/neurodata/scikit-tree/blob/9c84d6ff51996d2d151c92d14e68b4af70e5ea52/sktree/tests/test_honest_forest.py#L261-L335

Note, we have adapted the code a bit, and how the random_state is set in HonesTreeClassifier
@adam2392
Copy link
Collaborator Author

Cross-ref: #164

@adam2392 adam2392 mentioned this issue Nov 15, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adam2392