Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Change sktree.datasets.hyppo simulations n_informative < n_dim from error to warning #278

Closed
sampan501 opened this issue May 30, 2024 · 0 comments · Fixed by #279
Closed

ENH: Change sktree.datasets.hyppo simulations n_informative < n_dim from error to warning #278

sampan501 opened this issue May 30, 2024 · 0 comments · Fixed by #279
Assignees
@sampan501

Comments

@sampan501
Copy link
Member

sampan501 commented May 30, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.
When n_informative > n_dim we currently raise a ValueError. This means that every time we have a n_dim < 256, the user has to change both parameters.

Describe the solution you'd like
When n_informative < n_dim, we should set n_informative = n_dim and then raise a warning that we did so.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sampan501 sampan501

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change ValueError to RuntimeWarning when n_dim < n_informative neurodata/treeple
1 participant
@sampan501