Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add asv benchmarking files and benchmarking scripts #124

Merged
merged 1 commit into from
Sep 10, 2023
Merged

Conversation

adam2392
Copy link
Collaborator

@adam2392 adam2392 commented Sep 8, 2023

Fixes #27
Closes: #82

Changes proposed in this pull request:

  • Adds asv benchmarks to be able to run ASV benchmarking suite for tracking performance and runtime for estimators implemented
  • Adds a benchmarking folder containing scripts one can run locally to get an idea of the performance

These are heavily inspired from scikit-learn suite

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.

Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392 adam2392 marked this pull request as ready for review September 8, 2023 21:57
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9a325ae) 86.73% compared to head (a11abbe) 86.73%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #124   +/-   ##
=======================================
  Coverage   86.73%   86.73%           
=======================================
  Files          26       26           
  Lines        2111     2111           
=======================================
  Hits         1831     1831           
  Misses        280      280           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adam2392 adam2392 merged commit cf8e911 into main Sep 10, 2023
24 checks passed
@adam2392 adam2392 deleted the asv branch September 10, 2023 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BENCHMARKING] Implement asv benchmarks similar to scikit-learn
1 participant