Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add option to permute per forest fraction #145

Merged
merged 34 commits into from
Nov 9, 2023
Merged
Show file tree
Hide file tree
Changes from 19 commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
a3a002d
Add option to permute per forest fraction
adam2392 Oct 16, 2023
5277a5b
Add sep parallel func for building and predicting
adam2392 Oct 16, 2023
df3a1b1
Finished adding
adam2392 Oct 16, 2023
d46f1ad
Modify parallel building
adam2392 Oct 16, 2023
17b01ac
New submodule
adam2392 Oct 17, 2023
16122d3
Add additional pickle test
adam2392 Oct 17, 2023
7d42ac7
Add changelog
adam2392 Oct 17, 2023
4423377
Remove unnecessary comments
adam2392 Oct 17, 2023
1c8eedc
Merge branch 'main' into might-params
adam2392 Oct 17, 2023
5730b32
Remove extra LOC
adam2392 Oct 17, 2023
cd99a11
Merge branch 'might-params' of https://github.com/neurodata/scikit-tr…
adam2392 Oct 17, 2023
7fe487c
Merge branch 'main' into might-params
adam2392 Oct 17, 2023
6f978cb
Fix pvalue
adam2392 Oct 17, 2023
58d5365
Lint
adam2392 Oct 17, 2023
f5f282a
STart work on permute fraction of forest
adam2392 Oct 18, 2023
921eb2f
Merge branch 'main' into might-params
adam2392 Oct 19, 2023
261e359
Merge branch 'might-params' of https://github.com/neurodata/scikit-tr…
adam2392 Oct 19, 2023
0b167ba
Merging in main
adam2392 Oct 19, 2023
3674cc2
FIX add stratifi
PSSF23 Oct 23, 2023
0f27d01
Try stash
adam2392 Oct 24, 2023
e894708
UPdate and address permute forest fraction
adam2392 Oct 24, 2023
2887909
WIP
adam2392 Oct 24, 2023
739c7be
Adding ability to turn off train/test split
adam2392 Oct 24, 2023
30e9e95
Merging main
adam2392 Nov 8, 2023
36c5582
Fix type checK
adam2392 Nov 8, 2023
1ff7a5c
Fix typing
adam2392 Nov 8, 2023
c9c22e9
Fix ci
adam2392 Nov 8, 2023
2a6cda3
Remove fluff
adam2392 Nov 8, 2023
b183db1
Remove any mention of permute_per_tree
adam2392 Nov 8, 2023
8967d60
Merge branch 'main' into might-params
adam2392 Nov 9, 2023
59ae89b
Fix slow test
adam2392 Nov 9, 2023
2e1d53b
Try to fix slow
adam2392 Nov 9, 2023
f3aa7d7
Update
adam2392 Nov 9, 2023
9d0f2db
Lint
adam2392 Nov 9, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/whats_new/v0.3.rst
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ Changelog
- |Fix| Fixes a bug where covariate indices were not shuffled by default when running FeatureImportanceForestClassifier and FeatureImportanceForestRegressor test methods, by `Sambit Panda`_ (:pr:`140`)
- |Enhancement| Add multi-view splitter for axis-aligned decision trees, by `Adam Li`_ (:pr:`129`)
- |Enhancement| Add stratified sampling option to ``FeatureImportance*`` via the ``stratify`` keyword argument, by `Yuxin Bai`_ (:pr:`143`)
- |API| ``FeatureImportanceForest*`` now has a hyperparameter to control the number of permutations is done per forest ``permute_per_forest_fraction``, by `Adam Li`_ (:pr:`145`)

Code and Documentation Contributors
-----------------------------------
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@
stat, pvalue = est.test(
X, y, covariate_index=np.arange(n_features_set, dtype=int), metric="mi", n_repeats=n_repeats
)
print(f"Estimated MI difference: {stat} with Pvalue: {pvalue}")
print(f"Estimated MI difference for the important feature set: {stat} with Pvalue: {pvalue}")

# we test for the second feature set, which is unimportant and thus should return a pvalue > 0.05
stat, pvalue = est.test(
Expand All @@ -130,7 +130,7 @@
metric="mi",
n_repeats=n_repeats,
)
print(f"Estimated MI difference: {stat} with Pvalue: {pvalue}")
print(f"Estimated MI difference for the unimportant feature set: {stat} with Pvalue: {pvalue}")

# %%
# References
Expand Down
Loading
Loading