Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH add multi-view example #154

Merged
merged 5 commits into from
Oct 27, 2023
Merged

ENH add multi-view example #154

merged 5 commits into from
Oct 27, 2023

Conversation

PSSF23
Copy link
Member

@PSSF23 PSSF23 commented Oct 25, 2023

Fixes #

Changes proposed in this pull request:

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.

@codecov
Copy link

codecov bot commented Oct 25, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a81c597) 89.77% compared to head (2d23530) 89.77%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #154   +/-   ##
=======================================
  Coverage   89.77%   89.77%           
=======================================
  Files          41       41           
  Lines        3395     3395           
=======================================
  Hits         3048     3048           
  Misses        347      347

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

adam2392
adam2392 reviewed Oct 26, 2023
View reviewed changes
examples/hypothesis_testing/plot_might_mv_auc.py Outdated
Comment on lines 6 to 8
An example using :class:`~sktree.stats.FeatureImportanceForestClassifier` for nonparametric
multivariate hypothesis test, on simulated mutli-view datasets. Here, we present a simulation
of how MIGHT is used to evaluate how a "feature set is important for predicting the target".
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're not computing a pvalue, maybe just state we provide an API to simply estimate partial AUC?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I'll modify it/

@adam2392 adam2392 merged commit f7bb8f6 into main Oct 27, 2023
25 checks passed
@adam2392 adam2392 deleted the mv_example branch October 27, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adam2392 adam2392 adam2392 approved these changes

@sampan501 sampan501 sampan501 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PSSF23 @adam2392 @sampan501