Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX improve performance by updating max_features #161

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Conversation

PSSF23
Copy link
Member

@PSSF23 PSSF23 commented Oct 31, 2023

No description provided.

@PSSF23 PSSF23 requested a review from adam2392 October 31, 2023 13:43
Copy link
Member Author

@PSSF23 PSSF23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adam2392 this change should improve the mv performance, which is too low in the current example.

@adam2392
Copy link
Collaborator

Can you paste the rendered artifact link here? I can take a look on my phone.

Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f7bb8f6) 88.86% compared to head (5e90391) 88.86%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #161   +/-   ##
=======================================
  Coverage   88.86%   88.86%           
=======================================
  Files          41       41           
  Lines        3439     3439           
=======================================
  Hits         3056     3056           
  Misses        383      383           
Files Coverage Δ
sktree/__init__.py 77.77% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PSSF23
Copy link
Member Author

PSSF23 commented Oct 31, 2023

Can you paste the rendered artifact link here? I can take a look on my phone.

I don't know how to access it, but the local performance is 0.64/0.57, definitely better than what we have now.

@adam2392
Copy link
Collaborator

For future ref: under the GH-actions: build_docs links to the circleCI page and Artifacts uploaded has the html pages

@adam2392 adam2392 merged commit 386578a into main Oct 31, 2023
25 checks passed
@adam2392 adam2392 deleted the mv_example_fix branch October 31, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants