Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] issue#165 bug-fix #166

Merged
merged 1 commit into from
Nov 9, 2023
Merged

[FIX] issue#165 bug-fix #166

merged 1 commit into from
Nov 9, 2023

Conversation

SUKI-O
Copy link
Member

@SUKI-O SUKI-O commented Nov 3, 2023

Fixes #165

Changes proposed in this pull request:

  • Corrected indices n_features_views=[n_features_1, n_features_1+ n_features_2]

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (386578a) 88.86% compared to head (429f2b5) 88.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #166   +/-   ##
=======================================
  Coverage   88.86%   88.86%           
=======================================
  Files          41       41           
  Lines        3439     3439           
=======================================
  Hits         3056     3056           
  Misses        383      383           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SUKI-O SUKI-O marked this pull request as ready for review November 3, 2023 20:36
@SUKI-O SUKI-O changed the title issue#165 bug-fix [FIX] issue#165 bug-fix Nov 3, 2023
@SUKI-O SUKI-O requested a review from adam2392 November 4, 2023 12:32
@@ -92,12 +92,14 @@ def make_multiview_classification(

n_samples = 100
n_features = 10000
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe remove n_features altogether, unless it's used somewhere else?

Copy link
Collaborator

@adam2392 adam2392 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nitpick, but otw LGTM.

Copy link
Collaborator

@adam2392 adam2392 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adam2392 adam2392 merged commit a055049 into main Nov 9, 2023
25 checks passed
@adam2392 adam2392 deleted the sktree-165 branch November 9, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect indices in n_feature_views for co-might documentation
2 participants