Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add dataset generators #169

Merged
merged 8 commits into from
Nov 13, 2023
Merged

[ENH] Add dataset generators #169

merged 8 commits into from
Nov 13, 2023

Conversation

adam2392
Copy link
Collaborator

@adam2392 adam2392 commented Nov 9, 2023

Towards: #152

Changes proposed in this pull request:

  • Add methods to generate different datasets for regression, classification and hypothesis testing
  • adds the quadratic simulator from Samba's power simulation
  • adds multi view data generating models

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.

Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (e4728fa) 89.06% compared to head (9e4d02f) 89.59%.

❗ Current head 9e4d02f differs from pull request most recent head a670446. Consider uploading reports for the commit a670446 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
+ Coverage   89.06%   89.59%   +0.52%     
==========================================
  Files          41       46       +5     
  Lines        3531     3710     +179     
==========================================
+ Hits         3145     3324     +179     
  Misses        386      386              
Files Coverage Δ
sktree/datasets/__init__.py 100.00% <100.00%> (ø)
sktree/datasets/hyppo.py 100.00% <100.00%> (ø)
sktree/datasets/tests/test_hyppo.py 100.00% <100.00%> (ø)
sktree/datasets/tests/test_multiview.py 100.00% <100.00%> (ø)
sktree/stats/tests/test_coleman.py 100.00% <ø> (ø)
sktree/datasets/multiview.py 96.77% <96.77%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
CONTRIBUTING.md Outdated Show resolved Hide resolved
Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392 adam2392 merged commit 030a064 into main Nov 13, 2023
23 checks passed
@adam2392 adam2392 deleted the datasets branch November 13, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants