Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT, API Change trunk-classification into three separate functions for generating trunk, trunk-mix, trunk-overlap and marron-wand #227

Merged
merged 8 commits into from
Feb 23, 2024
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions doc/api.rst
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,8 @@ those offered in scikit-learn.
make_joint_factor_model
make_quadratic_classification
make_trunk_classification
make_trunk_mixture_classification
make_marron_wand_classification
approximate_clf_mutual_information
approximate_clf_mutual_information_with_monte_carlo

Expand Down
3 changes: 3 additions & 0 deletions doc/whats_new/v0.7.rst
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@ Changelog
by `Sambit Panda`_ (:pr:`#203`)
- |Feature| :func:`sktree.stats.build_coleman_forest` and :func:`sktree.stats.build_permutation_forest`
are added to compute p-values given an estimator and permutation-estimator, `Adam Li`_ (:pr:`#222`)
- |API| :func:`sktree.datasets.make_trunk_classification` for generating trunk mixture and Marron-Wand
simulations are separated out into :func:`sktree.datasets.make_marron_wand_classification` and
:func:`sktree.datasets.make_trunk_mixture_classification`, `Adam Li`_ (:pr:`#227`)
- |API| :class:`sktree.HonestForestClassifier` and :class:`sktree.tree.HonestTreeClassifier`
now overwrite all parameters set by the underlying ``tree_estimator`` and allow you to directly
pass any extra parameters that ``tree_estimator`` has compared to the original
Expand Down
2 changes: 2 additions & 0 deletions sktree/datasets/__init__.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
from .hyppo import (
approximate_clf_mutual_information,
approximate_clf_mutual_information_with_monte_carlo,
make_marron_wand_classification,
make_quadratic_classification,
make_trunk_classification,
make_trunk_mixture_classification,
)
from .multiview import make_gaussian_mixture, make_joint_factor_model
Loading
Loading