Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT honest API with a multi view #231

Merged
merged 15 commits into from
Feb 24, 2024
Merged

MAINT honest API with a multi view #231

merged 15 commits into from
Feb 24, 2024

Conversation

adam2392
Copy link
Collaborator

@adam2392 adam2392 commented Feb 23, 2024

Changes proposed in this pull request:

  • "inheritable" and common fitted parameters should go in the honest tree itself and the honest forest
  • Each classifier that extends __init__ of original BaseDecisionTree needs to have a _inheritable_fitted_attribute property defined returning a list of fitted attribute names
  • The HonestForest/Tree tries to set the relevant fitted attributes in addition to the inheritable fitted attributes

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.

Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392 adam2392 changed the title ENH honest API with a multi view MAINT honest API with a multi view Feb 23, 2024
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.81%. Comparing base (928a855) to head (97dcee4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #231      +/-   ##
==========================================
+ Coverage   89.67%   89.81%   +0.13%     
==========================================
  Files          54       54              
  Lines        4978     5026      +48     
==========================================
+ Hits         4464     4514      +50     
+ Misses        514      512       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392 adam2392 merged commit 48ca383 into main Feb 24, 2024
31 checks passed
@adam2392 adam2392 deleted the honestmultiview branch February 24, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants