Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT HonestForestClassifier now has bootstrap=True as the default. And removing old MIGHT code #274

Merged
merged 14 commits into from
Jun 11, 2024

Conversation

adam2392
Copy link
Collaborator

@adam2392 adam2392 commented May 6, 2024

Fixes #146

Changes proposed in this pull request:

  • bootstrap=True is the default now
  • Removed all instances of FeatureImportanceClassifier and other MIGHT methods that are outdated. This is in favor of the functional API used for (CO)MIGHT
  • There was a small bug in build_coleman_forest stemming from MAINT Fix CI #281 and ENH treeple tutorials should use native functions in scikit-tree #257 where the PermutationHonestForest should get passed covariate_index. It is not tested in test_comight_repeated_feature_sets.

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.

Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Copy link
Member

@sampan501 sampan501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sampan501
Copy link
Member

Pending unit test pass

Signed-off-by: Adam Li <adam2392@gmail.com>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will get refactored to use the latest API

@adam2392 adam2392 merged commit 3cfb082 into main Jun 11, 2024
30 of 31 checks passed
@adam2392 adam2392 deleted the honest branch June 11, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should HonestForest* have bootstrap=False or bootstrap=True as default
2 participants