Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change ValueError to RuntimeWarning when n_dim < n_informative #279

Merged
merged 9 commits into from
May 31, 2024

Conversation

sampan501
Copy link
Member

Closes #278

Changes proposed in this pull request:

  • Sets n_informative to n_dim when n_dim < n_informative
  • Raises a RuntimeWarning

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.

@sampan501 sampan501 requested a review from adam2392 May 30, 2024 15:35
@sampan501
Copy link
Member Author

I think errors are related to some issue with spin and not this PR

Copy link
Member

@PSSF23 PSSF23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed that the errors are not related to the changes.

Copy link
Member

@PSSF23 PSSF23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently the python version of CircleCI was wrong. I don't know how the tests pass in the past.

Copy link
Member

@PSSF23 PSSF23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue with build doc was confirmed to be associated with the latest sklearn==1.5.0, so we should have fixed it by modifying the import path.

Copy link
Member

@PSSF23 PSSF23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.11 seems too new.

@sampan501
Copy link
Member Author

3.11 seems too new.

I only did it since I thought it might be able to fix doc build issues, but it did not

Copy link
Member

@PSSF23 PSSF23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sampan501 doc problem solved. I'll open another one to work on tutorials so this one can be closed.

@PSSF23 PSSF23 merged commit 4a9f653 into main May 31, 2024
22 of 28 checks passed
@PSSF23 PSSF23 deleted the sim-error-fix branch May 31, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: Change sktree.datasets.hyppo simulations n_informative < n_dim from error to warning
2 participants