-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change ValueError
to RuntimeWarning
when n_dim < n_informative
#279
Conversation
I think errors are related to some issue with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed that the errors are not related to the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently the python version of CircleCI
was wrong. I don't know how the tests pass in the past.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue with build doc
was confirmed to be associated with the latest sklearn==1.5.0
, so we should have fixed it by modifying the import path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.11
seems too new.
I only did it since I thought it might be able to fix doc build issues, but it did not |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sampan501 doc problem solved. I'll open another one to work on tutorials so this one can be closed.
Closes #278
Changes proposed in this pull request:
n_informative
ton_dim
whenn_dim < n_informative
RuntimeWarning
Before submitting
section of the
CONTRIBUTING
docs.Writing docstrings section of the
CONTRIBUTING
docs.After submitting