Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the pkg to "treeple" #292

Merged
merged 6 commits into from
Jul 9, 2024
Merged

Rename the pkg to "treeple" #292

merged 6 commits into from
Jul 9, 2024

Conversation

SUKI-O
Copy link
Member

@SUKI-O SUKI-O commented Jul 7, 2024

Reference Issues/PRs

Change the package name from scikit-tree to treeple

What does this implement/fix? Explain your changes.

  • Replace scikit-tree to treeple
  • Replace sktree to treeple
  • Change the directory name sktree to treeple

Any other comments?

  • The name of the repo itself in GH also need to be changed when ready
  • After that, pypi has to be updated (I need help with this part)
  • It builds locally using spin as expected.
  • When trying locally, I believe you have to re-initialize the submodule
git submodule init
git submodule update

@SUKI-O SUKI-O requested a review from adam2392 July 7, 2024 19:39
@SUKI-O SUKI-O self-assigned this Jul 7, 2024
Copy link

codecov bot commented Jul 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.55%. Comparing base (52ac9e4) to head (4f67823).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #292   +/-   ##
=======================================
  Coverage   78.55%   78.55%           
=======================================
  Files          24       24           
  Lines        2252     2252           
  Branches      414      414           
=======================================
  Hits         1769     1769           
  Misses        352      352           
  Partials      131      131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adam2392
Copy link
Collaborator

adam2392 commented Jul 7, 2024

Mostly LGTM, but

  1. you'll need to fix the building of the documentation (https://app.circleci.com/pipelines/github/neurodata/scikit-tree/1741/workflows/345d4498-1b23-4ca7-8aaa-4dedf03eac94/jobs/2969?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link&utm_content=summary)
  2. in the CHANGELOG entry, you should add a summary specifying the entire package was renamed. https://github.com/neurodata/scikit-tree/blob/98b67fcbaf028ee8a9bd92407089ab4a34008e9b/doc/whats_new/v0.9.rst?plain=1#L11
  3. In the README, it would also be good to specify that in v0.9 and onwards, the package was renamed to treeple. <v0.8 is still installable via scikit-tree on pip.

@SUKI-O
Copy link
Member Author

SUKI-O commented Jul 7, 2024

@adam2392 I think the error is bc the repo name hasn't changed yet.. I think it should be fine once rename the repo itself? LMK what you think.

README.md Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
@adam2392
Copy link
Collaborator

adam2392 commented Jul 7, 2024

@SUKI-O I think we can make that final change once we confirm the CI functions as expected. Seems like there are still some leftover warnings. You can try resolving locally too

Copy link
Collaborator

@adam2392 adam2392 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to rename the sklearn_vs_sktree folder under examples/ to sklearn_vs_treeple to fix the CI error

doc/whats_new/v0.9.rst Outdated Show resolved Hide resolved
doc/whats_new/v0.9.rst Show resolved Hide resolved
@SUKI-O SUKI-O requested a review from adam2392 July 9, 2024 14:05
Copy link
Collaborator

@adam2392 adam2392 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @SUKI-O!

@adam2392 adam2392 merged commit 574a629 into main Jul 9, 2024
35 checks passed
@adam2392 adam2392 deleted the rename branch July 9, 2024 14:09
@SUKI-O SUKI-O mentioned this pull request Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants