-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename the pkg to "treeple" #292
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #292 +/- ##
=======================================
Coverage 78.55% 78.55%
=======================================
Files 24 24
Lines 2252 2252
Branches 414 414
=======================================
Hits 1769 1769
Misses 352 352
Partials 131 131 ☔ View full report in Codecov by Sentry. |
Mostly LGTM, but
|
@adam2392 I think the error is bc the repo name hasn't changed yet.. I think it should be fine once rename the repo itself? LMK what you think. |
@SUKI-O I think we can make that final change once we confirm the CI functions as expected. Seems like there are still some leftover warnings. You can try resolving locally too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to rename the sklearn_vs_sktree
folder under examples/
to sklearn_vs_treeple
to fix the CI error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @SUKI-O!
Reference Issues/PRs
Change the package name from
scikit-tree
totreeple
What does this implement/fix? Explain your changes.
scikit-tree
totreeple
sktree
totreeple
sktree
totreeple
Any other comments?
spin
as expected.