Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dropped bottleneck warning message #311

Closed
wants to merge 3 commits into from

Conversation

ryanhausen
Copy link
Contributor

Reference Issues/PRs

Fixes #310

What does this implement/fix? Explain your changes.

Drops a bottleneck warning that appears every import of treeple.stats, which can be too much if the user isn't using the functions that depend on bottleneck for nans.

Any other comments?

Rather than move the warning, it makes sense to drop it for now. I am working on a sparse implementation of some of the treeple.stats calculations that will involve a refactor and so the warning may have a better home somewhere else when I am done.

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.64%. Comparing base (e8c7de5) to head (91f6271).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #311      +/-   ##
==========================================
- Coverage   78.66%   78.64%   -0.02%     
==========================================
  Files          24       24              
  Lines        2264     2262       -2     
  Branches      417      417              
==========================================
- Hits         1781     1779       -2     
  Misses        352      352              
  Partials      131      131              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ryanhausen ryanhausen marked this pull request as ready for review August 8, 2024 13:50
@adam2392
Copy link
Collaborator

adam2392 commented Aug 8, 2024

We can wait to see the sparse refactor then. I think a warning message is still warranted when the user uses the relevant functions (not during import)

@ryanhausen
Copy link
Contributor Author

Closing this out. #317 has this incorporated into it.

@ryanhausen ryanhausen closed this Aug 20, 2024
@ryanhausen ryanhausen deleted the issue310 branch August 26, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bottleneck should not raise a warning unless relevant function in treeple.stats is called
2 participants