You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Currently the functionalities for fetching sample datasets are implemented in the sample_data.py module. This works well but the interface results in some awkwardly worded and repetitive expressions, e.g.:
Describe the solution you'd like
Perhaps it's better to refactor the functionality into a class named SampleData and have the interface look sth like below:
The current global variable DATA_DIR could be initialised as class attributes local_data_dir with the default value ~/.movement/data, but giving the user the option to send it elsewhere.
The global DATA_URL could be made into a class variable with a fixed value.
Context
This is not critical or urgent, just wondering which interface feels more intuitive and consistent to people.
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
Currently the functionalities for fetching sample datasets are implemented in the
sample_data.py
module. This works well but the interface results in some awkwardly worded and repetitive expressions, e.g.:Describe the solution you'd like
Perhaps it's better to refactor the functionality into a class named
SampleData
and have the interface look sth like below:The current global variable
DATA_DIR
could be initialised as class attributeslocal_data_dir
with the default value~/.movement/data
, but giving the user the option to send it elsewhere.The global
DATA_URL
could be made into a class variable with a fixed value.Context
This is not critical or urgent, just wondering which interface feels more intuitive and consistent to people.
The text was updated successfully, but these errors were encountered: