-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log to the console rather than print()
#235
Comments
In general (but not necessarily absolutely) I think |
I agree on this principle. In this case, it's very useful to quickly see the number of NaNs before/after an operation. Given the new utility functions that @lochhh has nicely refactored into the One way would be for |
I think I wouldn't expect to use logging to see this in a notebook necessarily, but an explicit call, so something like |
I agree, so perhaps we should modify that function in #209 to return the string? |
I assume @VascoSch92 meant that this should be logged to the console rather than printed (e.g. so verbosity can be changed by third parties).
Originally posted by @adamltyson in #209 (comment)
When reporting number of NaNs in filtering, we currently use a
print
statement to print this to the console, whilst also logging this to thelog
attribute of a DataArray.The text was updated successfully, but these errors were encountered: