We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.move
We currently have two ways of applying kinematics and filtering operations:
velocity = compute_velocity(ds.position)
velocity = ds.move.compute_velocity()
For more information on the accessor approach, refer to the relevant section of our documentation.
This dual approach leads to several issues:
Completely remove the accessor:
Things we will "lose" if we remove the accessor:
data_vars
validate
validate()
During our last meeting, we agreed that these benefits do not justify the added maintenance burden.
I'll leave this open for ~ 1 week, if no one objects, we will start the removal process.
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
The problem
We currently have two ways of applying kinematics and filtering operations:
velocity = compute_velocity(ds.position)
velocity = ds.move.compute_velocity()
For more information on the accessor approach, refer to the relevant section of our documentation.
This dual approach leads to several issues:
.move
keyword) to new users, especially those unfamiliar with object-oriented programming.Proposed solution
Completely remove the accessor:
Alternatives
Additional considerations
Things we will "lose" if we remove the accessor:
data_vars
argument).validate
method, which we were considering removing anyway (Do we need avalidate()
method in move accessor? #257).During our last meeting, we agreed that these benefits do not justify the added maintenance burden.
I'll leave this open for ~ 1 week, if no one objects, we will start the removal process.
The text was updated successfully, but these errors were encountered: