Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURES REQUEST ]: window shadow #67

Open
JE-Amouel opened this issue Sep 2, 2024 · 5 comments
Open

[FEATURES REQUEST ]: window shadow #67

JE-Amouel opened this issue Sep 2, 2024 · 5 comments

Comments

@JE-Amouel
Copy link

Hi,

Describe the feature
There is something I would really like to add to my desktop theme to make it even more sophisticated and personalized and I would like to share it with you,
it is window shadow,
I would like to be able to add a shadow behind the current window to give it a floating effect when I focus on it,
if possible some option to adjust the projection of the shadow, like the distance between the shadow and the window as well as the angle of propagation of the shadow to be able to decide the position of the shadow relative to the window.

Thanks.

@neuromorph
Copy link
Owner

Hello,

I would like to be able to add a shadow behind the current window to give it a floating effect when I focus on it,

From what I see, there is already shadow behind the current window in Gnome. Though the floating effect, not as much, it is more of a diffused shadow all around.
The shadow is actually made up of several shadows in layers to accomplish a smooth effect, typically 5 - 6 shadows. Each one has 5 parameters other than color. That ends up being too many params to tweak if we want to adjust the projection angle and distance. There are some ways to auto-compute the params from the projection details but I haven't looked into it. A good floating effect should also consider the background color and incorporate it in the shadows but in our case background will be dynamic. Additionally, the shadows are only applicable for Light theme, they don't make much difference in Dark mode. TL;DR it is a bit more involved for the benefit to gain.

Let me try to fiddle with and create a shadow effect that is more aligned with floating window but without the projection adjustment. You can then try if that works better. I will let you know here.

@neuromorph
Copy link
Owner

Let me try to fiddle with and create a shadow effect that is more aligned with floating window but without the projection adjustment. You can then try if that works better. I will let you know here.

There is now an option for a modified shadow in the Gtk/Flatpak apps section in the latest version available in main branch here on GitHub. The Gtk section has been updated a bit along with some other enhancements e.g. ability to interact with panel buttons without having to precisely point on it.
Please try it out by installing the extension by downloading from the main branch and let me know about any feedback you may have.

@JE-Amouel
Copy link
Author

Please try it out by installing the extension by downloading from the main branch and let me know about any feedback you may have.

it really good all new features added, specially for hint color customization,
i just hope that window shadow settings will be more advanced.

might be good to see options like this 👇
Drawing 2024-09-10 04 41 18 excalidraw

@neuromorph
Copy link
Owner

it really good all new features added, specially for hint color customization,

👍

might be good to see options like this 👇

Yeh, though it is a bit more involved due to multiple shadows as mentioned earlier. Option to be able to choose the light source position relative to the window might be ideal but it would be something to look into, in the future.

@JE-Amouel
Copy link
Author

JE-Amouel commented Sep 15, 2024

take your time, I'm sure that in your hands, the final result will be much more than breathtaking,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants