Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

exclude js and eslint processing in src/static folder #4

Closed
eliperelman opened this issue Feb 7, 2017 · 8 comments
Closed

exclude js and eslint processing in src/static folder #4

eliperelman opened this issue Feb 7, 2017 · 8 comments
Assignees
Milestone

Comments

@eliperelman
Copy link
Member

From @gasolin on December 27, 2016 9:37

It's always happen when dev need to put some vendor libraries in code base.

Copied from original issue: mozilla-neutrino/neutrino-preset-web#7

@eliperelman
Copy link
Member Author

In order to do this, we would need to standardize what the default static directory is, e.g. src/static. Contenders could be static, public, or assets. I believe there would also need to be other config changes needed to support this.

@eliperelman
Copy link
Member Author

From @gasolin on January 6, 2017 2:3

I saw some configuration use static as non processed folder, and assets as recommend processable folder.. (Though I forget the source)

@eliperelman
Copy link
Member Author

A good directory name could also be "vendor".

@eliperelman
Copy link
Member Author

Putting these directories outside src would also work, without any Neutrino changes.

@eliperelman eliperelman added this to the v6 milestone May 4, 2017
@eliperelman
Copy link
Member Author

@mozilla-neutrino/core-contributors I'd like to settle on an agreed-upon directory name as the default directory for static/non-compiled assets. Most likely this would still live within the source directory so relative path roots would work correctly.

@jaridmargolin
Copy link
Contributor

As you described it as "static/non-compiled assets", I would move forward with static. Semantically it makes sense. It was also the name I gravitated towards.

Specifically, I'm not a huge fan of vendor. I believe it is unnecessarily specific. There could be multiple reasons a file is needed to be static.


I also like the idea of keeping of it in the source directory but don't have a concrete argument... just intuition.

@constgen
Copy link
Contributor

It is also important to work like http.get('/static/data.json').then(). So I think the name and place is correct. If nobody has no additional ideas I am ready to start work on a middleware.

@eliperelman
Copy link
Member Author

Resolved in #235.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

3 participants