-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XRDP v0.9.22 - Session chooser (login) segfaults if I click on 'Session' - libcommon.so.0.0.0 #2687
Comments
I can reproduce this on CentOS 8 and in my development environment. As far as CentOS 8 goes, at the moment 0.9.22-4 is in testing, so I needed to install it (and xrdp-selinux) manually. This looks like a problem with our stuff, rather than the EPEL build this time. It looks like 8810d46 is missing from this release. If I cherry-pick that in, the session chooser is fine. @bsmojver - I've raised https://bugzilla.redhat.com/show_bug.cgi?id=2208248 @metalefty - we'll need a 0.9.22.1 release. I'll look to see if anything else is missing. |
There are quite a few things in the v0.9.22 release note which aren't in the tarball - see |
Thanks. I linked the two RH bugs now. PS. Anything before -4 is definitely my error. I failed to include important .so files in the package. |
I also added a bug report -> https://bugzilla.redhat.com/show_bug.cgi?id=2208015 |
@matt335672 Thanks for the investigation. Guys, I will release a fixed version v0.9.22.1 soon. Sorry for the inconvenience. |
I suppose the breakage is caused by my mistakes during release process. Sorry for the breakage. This is not an official v0.9.22.1 release yet but should be a correct v0.9.22 tarball and will be re-released as v0.9.22.1. @matt335672 @bsmojver Can you test this pre-release tarball? |
I can definitely see the segrault patch in the diff, so that's good. I also see removals of g_malloc/free/memset/memcpy, which (from memory) was in release notes. And there is pamconfdir stuff too. There are also some other changes there, like audin. smartcard stuff etc. In summary, yeah - the pre tarball picked up more stuff, it seems. |
I'm not sure about the submodule versions in the tarball. I'd like a second opinion, as I may be reading this wrong. In the tarball, /* progressive blockType */
#define PRO_WBT_SYNC 0xCCC0
#define PRO_WBT_FRAME_BEGIN 0xCCC1
#define PRO_WBT_FRAME_END 0xCCC2
#define PRO_WBT_CONTEXT 0xCCC3
#define PRO_WBT_REGION 0xCCC4
#define PRO_WBT_TILE_SIMPLE 0xCCC5
#define PRO_WBT_TILE_PROGRESSIVE_FIRST 0xCCC6
#define PRO_WBT_TILE_PROGRESSIVE_UPGRADE 0xCCC7 This block was added for commit neutrinolabs/librfxcodec@34d0513 (PR is neutrinolabs/librfxcodec#50). This is merged in the devel branch. However, I believe the librfxcodec submodule commit for the xrdp v0.9 branch is neutrinolabs/librfxcodec@d8f126a :-
Here's a link to that version of the file:- It doesn't contain the block above. |
I have released the correct tarball v0.9.22.1. Double-checked by me and @matt335672 . |
Thanks! Building Fedora packages now. PS. It looks like on EPEL7, we'll need -std=c99 gcc option. Testing now. |
Hi.
I have another issue (perhaps related to #2682 ?)
Pretty sure this didn't occur before (when I just had KDE installed)
If I enter no password when logging in I get the XRDP login menu - where you choose session, user, pass.
If I click on the session drop down menu (i.e xorg, XVNC) (at all) it crashes (100% on the time, on 2 different systems..)
e.g
It works otherwise as long as you do not click ...
i.e I can use tab key to enter the session drop down (and it doesn't crash) - which seems like a really odd error.
Any ideas ?
edit: It appears to be connected to the new version (i'm using EPEL packages) - xrdp-0.9.22-4.el8.x86_64.rpm - this happens on - if I downgrade again to xrdp-0.9.21-1.el8.x86_64.rpm this issue is not there .
The text was updated successfully, but these errors were encountered: