Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Tenor Banjo #15

Open
jgarte opened this issue Jun 11, 2023 · 2 comments
Open

Feature Request: Tenor Banjo #15

jgarte opened this issue Jun 11, 2023 · 2 comments

Comments

@jgarte
Copy link
Contributor

jgarte commented Jun 11, 2023

Hi,

The difference between a tenor banjo and a tenor guitar is just the timbre or sound (e.g. a different MIDI instrument).

How should we add this and introduce the tenor banjo?

@newlandsvalley
Copy link
Owner

Well I've always considered sounding the instrument as an optional extra - originally Sturla didn't even want this feature and I added it simply because I could. And many of the MIDI instruments sound pretty terrible anyway, although I think the banjo sounds OK.

So, I have no great desire to add this feature and I feel it will complicate the UI for very little gain. We wouldn't want all that extra copying to create a new instrument which is virtually identical. The only thing I can think of is to call it the Tenor Guitar / Banjo and then alternate between the two sounds when the user plays it.

@jgarte
Copy link
Contributor Author

jgarte commented Jun 13, 2023

I agree that we shouldn't copy code for this.

I was thinking of something with a configurable design. Not sure yet how to achieve that though.

Toggling between the two timbres sounds like one approach that could work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants