Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3 agent: Support jackc/pgx as a postgres driver #179

Closed
jodeev opened this issue Jul 13, 2020 · 3 comments · Fixed by #363
Closed

v3 agent: Support jackc/pgx as a postgres driver #179

jodeev opened this issue Jul 13, 2020 · 3 comments · Fixed by #363

Comments

@jodeev
Copy link
Contributor

jodeev commented Jul 13, 2020

Our existing nrpq integration package needs an update. we need to add support for the jackc/pgx driver.

The currently supported driver is https://github.com/lib/pq, which is now in maintenance mode. That repo says to use https://github.com/jackc/pgx instead.

More importantly, lib/pq doesn't have any intelligent retry logic, whereas pgx does retry queries on certain safe kinds of errors. Users need this to do things such as handle broken pipes.

Acceptance criteria

Original issue: #142

@jodeev jodeev changed the title Support jackc/pgx as a postgres driver v3 agent: Support jackc/pgx as a postgres driver Jul 21, 2020
@jodeev jodeev added the roadmap label Aug 27, 2020
@jodeev
Copy link
Contributor Author

jodeev commented Sep 22, 2020

Comment added by Jon Connelly in Aha! - View

@Jodee Varney does this relate to updating the driver?

My customer has a support issue that suggests it could be solved by updating the Go driver and I want to confirm this is the enhancement request that would relate to the issue. Thank you for any insights.

Support case: https://newrelic.zendesk.com/agent/tickets/413756

"I’m pretty out of ideas on this one. Unfortunately, we couldn’t update to the latest version of the driver because it requires a newer version of Go than the one the integrations are built with, so it’s still possible that could help, but it’s not really doable right now. I’m unable to reproduce it myself, and don’t really have any more information I can think of that might help"

@Miriam-R Miriam-R added the p2 Priority 2 work items label Nov 6, 2020
@marcesher
Copy link

Huge +100 for this one!

@RichVanderwal
Copy link
Contributor

This has been moved into the roadmap for completion in August.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants