Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GUIDE.md regarding StartExternalSegment #252

Closed
RichVanderwal opened this issue Dec 3, 2020 · 1 comment · Fixed by #320
Closed

Fix GUIDE.md regarding StartExternalSegment #252

RichVanderwal opened this issue Dec 3, 2020 · 1 comment · Fixed by #320
Assignees
Labels
p2 Priority 2 work items

Comments

@RichVanderwal
Copy link
Contributor

For some reason, the GUIDE.md file tells our customers to use StartExternalSegment as a function that's available on a transaction. We changed this 4.5 years ago.

Rewrite this to make sense for our customers.

Also, it'd be great to know how the GUIDE.md got into this strange state. the StartExternalSegment function didn't even exist when we moved segment starts out of the transaction, and instead provided the transaction as a parameter to the call -- it was just StartSegment at the time.

@RichVanderwal RichVanderwal created this issue from a note in Go Engineering Board (To Do) Dec 3, 2020
@RichVanderwal RichVanderwal added the p2 Priority 2 work items label Dec 3, 2020
@RichVanderwal
Copy link
Contributor Author

@jodeev says: We should thank the customer (point to the explorer hub post) in the PR and if applicable, in release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2 Priority 2 work items
Development

Successfully merging a pull request may close this issue.

1 participant