Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests fail for v3/integrations/nrgrpc #344

Closed
pymnh opened this issue Jul 16, 2021 · 3 comments · Fixed by #345
Closed

tests fail for v3/integrations/nrgrpc #344

pymnh opened this issue Jul 16, 2021 · 3 comments · Fixed by #345
Labels

Comments

@pymnh
Copy link

pymnh commented Jul 16, 2021

Hi. For v3.14.0, tests for v3/integrations/nrgrpc are failing with following error:

% go test
--- FAIL: TestUnaryServerInterceptorError (0.00s)
    expect_implementation.go:27: error events value difference key=error.class gRPC Status: DataLoss gRPC Error: DataLoss
--- FAIL: TestStreamServerInterceptorError (0.00s)
    expect_implementation.go:27: error events value difference key=error.class gRPC Status: DataLoss gRPC Error: DataLoss
FAIL
exit status 1
FAIL	github.com/newrelic/go-agent/v3/integrations/nrgrpc	0.048s
@pymnh pymnh added the bug label Jul 16, 2021
@nr-swilloughby
Copy link
Contributor

Thanks for the heads up. We'll look into that and also why the tests passed for us but failed later when installed.

@nr-swilloughby
Copy link
Contributor

That was a typo in the testcase. It's been corrected in our development branch and will be released ASAP.

@RichVanderwal RichVanderwal linked a pull request Jul 16, 2021 that will close this issue
@nr-swilloughby
Copy link
Contributor

This has been fixed in the 3.14.1 go-agent release (nrgrpc integration 1.3.1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants