Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Grpc* transaction attribute names to conform to standard convention #492

Closed
nr-swilloughby opened this issue May 13, 2022 · 0 comments · Fixed by #523, #531 or newrelic/docs-website#8258
Closed

Rename Grpc* transaction attribute names to conform to standard convention #492

nr-swilloughby opened this issue May 13, 2022 · 0 comments · Fixed by #523, #531 or newrelic/docs-website#8258
Assignees
@mirackara
Labels
bug good first issue

Comments

@nr-swilloughby
Copy link
Contributor

Description

The gRPC attributes added in the error-handling portion of the nrgrpc integration start with upper-case letters:
GrpcStatusLevel
GrpcStatusMessage
GrpcStatusCode

to be consistent with established conventions for agent attributes, they should start with lower-case letters:
grpcStatusLevel
grpcStatusMessage
grpcStatusCode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mirackara mirackara

Labels
bug good first issue
Projects
None yet
Milestone
No milestone
2 participants
@mirackara @nr-swilloughby