Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Region Constants reference Deprecated API Endpoints #844

Open
tcgbrett opened this issue Dec 28, 2021 · 4 comments
Open

Region Constants reference Deprecated API Endpoints #844

tcgbrett opened this issue Dec 28, 2021 · 4 comments
Labels
pinned Pin an issue to prevent auto-closing by a bot.

Comments

@tcgbrett
Copy link

Description

The restBaseURL in pkg/region/region_constants.go refers to api.newrelic.com/v2 which is deprecated for Dashboard interaction. That means the whole Dashboards package can't actually interact with the new NerdGraph API.

Go Version

go version go1.17.2 darwin/amd64

Current behavior

When I use the dashboards package, the URL points to a deprecated endpoint, so the request fails.
The failure

error creating dashboard:410 response returned: This endpoint is deprecated: Please see documentation on migrating to NerdGraph, our GraphQL API, here:, https://docs.newrelic.com/docs/new-relic-one/use-new-relic-one/core-concepts/dashboards-api-migration-insights-api-nerdgraph, and check the announcement: https://discuss.newrelic.com/t/important-insights-dashboard-api-end-of-life/149357

I changed my local NR code in pkg/dashboards/dashboard.go to print what the devised URL is, and it does confirm my suspicions. I changed this to a print statement

	url := d.config.Region().RestURL("dashboards.json")
	log.Println("Built URL: ", url)

And it printed: Built URL: https://api.newrelic.com/v2/dashboards.json

Expected behavior

This should interact with a non-deprecated API so it's usable.

Steps To Reproduce

Steps to reproduce the behavior:
Try to use client.CreateDashboard(*db) and it will fail.

@stale
Copy link

stale bot commented Jan 14, 2022

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Issue or PR has been inactive for a period of time. This label is configured in stale-bot. label Jan 14, 2022
@tcgbrett
Copy link
Author

... I would not like this issue closed. I would like if someone from NR responded.

@stale stale bot removed the stale Issue or PR has been inactive for a period of time. This label is configured in stale-bot. label Jan 18, 2022
@michaelprice232
Copy link

This is affecting us as well so would be keen on a fix

@stale
Copy link

stale bot commented Feb 19, 2022

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Issue or PR has been inactive for a period of time. This label is configured in stale-bot. label Feb 19, 2022
@kidk kidk added pinned Pin an issue to prevent auto-closing by a bot. and removed stale Issue or PR has been inactive for a period of time. This label is configured in stale-bot. labels Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pinned Pin an issue to prevent auto-closing by a bot.
Projects
None yet
Development

No branches or pull requests

3 participants