Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report failed target but don't bail on whole manifest #37

Open
jsumners-nr opened this issue Sep 17, 2024 · 0 comments
Open

Report failed target but don't bail on whole manifest #37

jsumners-nr opened this issue Sep 17, 2024 · 0 comments

Comments

@jsumners-nr
Copy link
Contributor

See the discussion in #36 (review)

Currently, we will bail on a versioned test manifest completely if any target in that manifest fails for some reason. Known reasons are 1. target is defined but there is not a correlating dependency in the tests and 2. same as 1, but the minSupported attribute has been omitted. In other words, both of these are valid and should pass:

{
	targets: [{
		name: 'foo', minAgentVersion: '1.2.3'
	}],

	tests: [{
		dependencies: { 'foo': '>=1.0.0' },
		files: [ 'whatever.test.js' ]
	}]
}
{
	targets: [{
		name: 'foo', minSupported: '1.0.0', minAgentVersion: '1.2.3'
	}],

	tests: [{
		files: [ 'whatever.test.js' ]
	}]
}

We need to construct a test case that fails, and then refactor the implementation to only report the error for the offending target but continue with other targets in the manifest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Triage Needed: Unprioritized Features
Development

No branches or pull requests

2 participants