Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture AWS SQS info on message spans #1183

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Conversation

hmstepanek
Copy link
Contributor

Overview

Capture AWS SQS agent attributes on message spans.

@hmstepanek hmstepanek requested a review from a team July 24, 2024 22:27
Copy link

github-actions bot commented Jul 24, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 3 0 5.06s
✅ PYTHON black 4 0 0 1.23s
✅ PYTHON flake8 4 0 0.65s
✅ PYTHON isort 4 0 0 0.31s
✅ PYTHON pylint 4 0 3.94s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 82.22222% with 8 lines in your changes missing coverage. Please review.

Project coverage is 81.63%. Comparing base (a4ca19d) to head (28a984d).

Files Patch % Lines
newrelic/hooks/external_botocore.py 80.95% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1183      +/-   ##
==========================================
- Coverage   81.66%   81.63%   -0.04%     
==========================================
  Files         196      196              
  Lines       21696    21736      +40     
  Branches     3789     3795       +6     
==========================================
+ Hits        17718    17744      +26     
- Misses       2880     2889       +9     
- Partials     1098     1103       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hmstepanek hmstepanek force-pushed the capture-aws-sqs-info branch 3 times, most recently from b9ae884 to a401d21 Compare July 25, 2024 21:36
params={},
terminal=True,
async_wrapper=None,
extract_agent_attrs=None,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't particularly care for muddying the public APIs with this. Can we instead define an SQS wrapper in the botocore instrumentation that starts a message trace, and adds the necessary attrs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've recreated a simpler wrapper inside the botocore instrumentation that contains the call to create the agent attributes.

@hmstepanek hmstepanek merged commit 60fe0b6 into main Aug 1, 2024
51 of 52 checks passed
@hmstepanek hmstepanek deleted the capture-aws-sqs-info branch August 1, 2024 01:14
@mergify mergify bot removed the tests-failing label Aug 1, 2024
@umaannamalai umaannamalai added this to the v9.13.0 milestone Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants