-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capture AWS SQS info on message spans #1183
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1183 +/- ##
==========================================
- Coverage 81.66% 81.63% -0.04%
==========================================
Files 196 196
Lines 21696 21736 +40
Branches 3789 3795 +6
==========================================
+ Hits 17718 17744 +26
- Misses 2880 2889 +9
- Partials 1098 1103 +5 ☔ View full report in Codecov by Sentry. |
b9ae884
to
a401d21
Compare
newrelic/api/message_trace.py
Outdated
params={}, | ||
terminal=True, | ||
async_wrapper=None, | ||
extract_agent_attrs=None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't particularly care for muddying the public APIs with this. Can we instead define an SQS wrapper in the botocore instrumentation that starts a message trace, and adds the necessary attrs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've recreated a simpler wrapper inside the botocore instrumentation that contains the call to create the agent attributes.
9fa3fd5
to
6e4a169
Compare
f948774
to
28a984d
Compare
Overview
Capture AWS SQS agent attributes on message spans.