Enable Logging while disabling Forwarding & Instrumentation

[chriscz]

Is your feature request related to a problem? Please describe.

No

Feature Description

I want to enable logging and submit logs to NewRelic without using the built-in forwarding so that I can make use of a custom gem's log forwarding facilities SemanticLogger. There is an open issue tracking this problem for which I am working on a PR.

In addition to the above, a public logging API would be great so that instead of

::NewRelic::Agent.agent.log_event_aggregator.record(formatted_message, severity) 

you would do

::NewRelic::Agent.log(:debug, "message_string_or_hash_payload", exception: nil)

Describe Alternatives

• Integrating the HTTP Logging API
• Monkey patching New Relic

Additional context

Instrumentation

newrelic-ruby-agent/lib/new_relic/agent/instrumentation/logger/instrumentation.rb

Lines 44 to 61 in 9471a2c

	def format_message_with_tracing(severity, datetime, progname, msg)
	formatted_message = yield
	return formatted_message if skip_instrumenting?
	begin
	# It's critical we don't instrument logging from metric recording
	# methods within NewRelic::Agent, or we'll stack overflow!!
	mark_skip_instrumenting
	unless ::NewRelic::Agent.agent.nil?
	::NewRelic::Agent.agent.log_event_aggregator.record(formatted_message, severity)
	formatted_message = LocalLogDecorator.decorate(formatted_message)
	end
	formatted_message
	ensure
	clear_skip_instrumenting
	end

Logging Event Code

newrelic-ruby-agent/lib/new_relic/agent/log_event_aggregator.rb

Lines 54 to 84 in 9471a2c

	def record(formatted_message, severity)
	return unless enabled?
	severity = "UNKNOWN" if severity.nil? || severity.empty?
	if NewRelic::Agent.config[METRICS_ENABLED_KEY]
	@counter_lock.synchronize do
	@seen += 1
	@seen_by_severity[severity] += 1
	end
	end
	return if formatted_message.nil? || formatted_message.empty?
	return unless NewRelic::Agent.config[:'application_logging.forwarding.enabled']
	return if @high_security
	txn = NewRelic::Agent::Transaction.tl_current
	priority = LogPriority.priority_for(txn)
	if txn
	return txn.add_log_event(create_event(priority, formatted_message, severity))
	else
	return @lock.synchronize do
	@buffer.append(priority: priority) do
	create_event(priority, formatted_message, severity)
	end
	end
	end
	rescue
	nil
	end

Priority

Must Have

Related Issues

• Adding custom attributes to the logs via the agent #1141

[workato-integration]

https://issues.newrelic.com/browse/NEWRELIC-5265

[kaylareopelle]

Hi @chriscz, thanks for submitting this feature request! We're reviewing it as a team. Right now, consider this issue as gathering interest. Any customers who come across it should comment or use an emoji to show their interest in the feature!

Someone from our team will be in touch if we have questions about what your request.

[kaylareopelle]

Also, thank you for your work to make SemanticLogger compatible with the Ruby agent! I'm glad you were able to find the local decorator in your search.

[workato-integration]

This issue won't be actioned.

[tannalynn]

We've decided to close this issue because this isn't a method we want to add to the agent's public API at this time.