Support cgroups v1 and v2 for Docker containers #2229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the agent was only capable of gleaning a Docker container id by leveraging a cgroups v1 approach. Now, it will first attempt to leverage a cgroups v2 approach and fall back to the v1 approach if that doesn't work. All other Docker related behavior such as that seen with containers that don't have cgroups functionality enabled is not impacted.
fallwith
requested review from
hannahramadan,
kaylareopelle and
tannalynn
as code owners
kaylareopelle
previously approved these changes
Sep 21, 2023
Update CHANGELOG for the Docker container id support for cgroups v2 / PR 2026
For the Docker container id support for cgroups v2, reference the PR, not the Issue
Co-authored-by: Kayla Reopelle (she/her) <87386821+kaylareopelle@users.noreply.github.com>
kaylareopelle
approved these changes
Sep 21, 2023
SimpleCov Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the agent was only capable of gleaning a Docker container id by leveraging a cgroups v1 approach. Now, it will first attempt to leverage a cgroups v2 approach and fall back to the v1 approach if that doesn't work. All other Docker related behavior such as that seen with containers that don't have cgroups functionality enabled is not impacted.
resolves #2026