Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActiveSupport notifications improvements #2685

Open
fallwith opened this issue Jun 3, 2024 · 1 comment
Open

ActiveSupport notifications improvements #2685

fallwith opened this issue Jun 3, 2024 · 1 comment
Assignees

Comments

@fallwith
Copy link
Contributor

fallwith commented Jun 3, 2024

With #2610 we made a number of ActiveSupport notifications related improvements in response to a GTSE. That GTSE was closed out automatically due to lack of activity, but we anticipate it or a similar one coming back in the future. In the meantime, this issue will serve as a placeholder to remind of us of what work was done. If we hear back via a new GTSE, then we can obviously do what it takes to address it. Otherwise, we ought to still consider salvaging some of the work done for #2610 for the benefit of all Rails using customers.

In summary, #2610 delivered all of the following:

  • Defined a new configuration parameter, :'instrumentation.active_support_notifications.active_support_events', to serve as an allowlist of ActiveSupport specific notifications (notifications related to the use of the ActiveSupport library itself; of course notifications themselves are defined by ActiveSupport, but this list is related to the usage of the gem itself).
    • By default, the list has every publicly (HTML) documented notification
    • Notifications absent from the allow list are not even subscribed to by the agent
  • A static (frozen hash) map of notification to method name is defined to simplify and speed up method name gleaning
  • Support for the 'message_serializer_fallback.active_support' was added. Currently the agent only supports 'cache_*' related notifications
  • #delete_prefix and #delete_suffix were introduced to deliver the position related transformations proven out by @kaylareopelle to deliver a performance boost.

With or without hearing back on the GTSE, we ought to move forward with one or more items from this list. Ideally, we should also agree to queue up additional work to bring the relevant changes to our other notifications based instrumentations.

@fallwith fallwith added the apr-jun qtr Represents proposed work item for the Apr-Jun quarter label Jun 3, 2024
@fallwith fallwith self-assigned this Jun 3, 2024
@workato-integration
Copy link

@kford-newrelic kford-newrelic removed the apr-jun qtr Represents proposed work item for the Apr-Jun quarter label Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants