Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: reduce duplication in the error helper #2322

Closed
amychisholm03 opened this issue Jul 1, 2024 · 1 comment · Fixed by #2328
Closed

refactor: reduce duplication in the error helper #2322

amychisholm03 opened this issue Jul 1, 2024 · 1 comment · Fixed by #2328
Assignees
@amychisholm03
Labels
points: 1 1 day or less

Comments

@amychisholm03
Copy link
Contributor

There are multiple isExpected functions--one in the helper, and one in the errors class definition. And an evaluation would turn up more duplication.

Second half of https://new-relic.atlassian.net/browse/NR-96722
@workato-integration
Copy link

https://new-relic.atlassian.net/browse/NR-287078

@amychisholm03 amychisholm03 self-assigned this Jul 1, 2024
@amychisholm03 amychisholm03 changed the title Reduce duplication in the error helper refactor: reduce duplication in the error helper Jul 1, 2024
@amychisholm03 amychisholm03 linked a pull request Jul 3, 2024 that will close this issue
refactor: got rid of redundant isExpected in the Exception class #2328
Merged
@kmudduluru kmudduluru added the points: 1 1 day or less label Jul 3, 2024
@bizob2828 bizob2828 moved this to Done: Issues recently completed in Node.js Engineering Board Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amychisholm03 amychisholm03

Labels
points: 1 1 day or less
Projects
Node.js Engineering Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: got rid of redundant isExpected in the Exception class amychisholm03/node-newrelic
2 participants
@amychisholm03 @kmudduluru