Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ControlPlane: collect admission controller duration statistics #820

Closed
Emberwalker opened this issue Aug 1, 2023 · 3 comments
Closed

ControlPlane: collect admission controller duration statistics #820

Emberwalker opened this issue Aug 1, 2023 · 3 comments
Labels
feature request Categorizes issue or PR as related to a new feature or enhancement.

Comments

@Emberwalker
Copy link

Description

Currently the k8sApiServerSample does not include the API Server apiserver_admission_controller_admission_duration_seconds metric, which can be useful in diagnosing latency problems with the API Server that are caused by misbehaving admission controllers (where one blocks for an extended time on e.g. CREATE requests). Without these metrics, cluster administrators need to either also run a regular Prometheus instance to collect this data, or a custom OTel Collector in order to gather these stats. Would it be possible to get this metric included in the default sample?

Expected Behavior

The API Server apiserver_admission_controller_admission_duration_seconds metric is scraped and stored in the k8sApiServerSample as a new metric (e.g. k8s.apiserver.admission.duration)

Troubleshooting or NR Diag results

N/A

Steps to Reproduce

Compare reported metrics from the API Server metrics endpoint with metrics exposed under k8s.apiserver. in New Relic.

Your Environment

Kubernetes 1.23 and 1.24, NRI Bundle 4.3.1, NRI-Kubernetes 3.15.1

Additional context

This metric was referenced in issue #445 but was not added as a result of that ticket.

For Maintainers Only or Hero Triaging this bug

Suggested Priority (P1,P2,P3,P4,P5):
Suggested T-Shirt size (S, M, L, XL, Unknown):

@Emberwalker Emberwalker added the bug Categorizes issue or PR as related to a bug. label Aug 1, 2023
@workato-integration
Copy link

@davidgit davidgit added feature request Categorizes issue or PR as related to a new feature or enhancement. and removed bug Categorizes issue or PR as related to a bug. labels Aug 3, 2023
@mangulonr
Copy link
Contributor

Hi Ember
Thanks for creating this request.
It will be taken into account when prioritizing next projects.

@workato-integration
Copy link

This issue won't be actioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Categorizes issue or PR as related to a new feature or enhancement.
Projects
None yet
Development

No branches or pull requests

3 participants