Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable NEW_RELIC_LICENSE_KEY env variable #428

Open
larivierec opened this issue Mar 28, 2024 · 3 comments
Open

Disable NEW_RELIC_LICENSE_KEY env variable #428

larivierec opened this issue Mar 28, 2024 · 3 comments
Assignees

Comments

@larivierec
Copy link

While this is offered as a feature, it essentially leaks the license key to environment variables when it's not managed by the initial cloudformation deployment.

We have many lambdas and reuse some of the license keys so not every stack can recreate the secret in a cross-account scenario.
You should allow us to be able to disable the templating of the environment variable NEW_RELIC_LICENSE_KEY completely.

I propose that a variable similar to the disableLicenseKeySecret is added to the options or a selfManagedSecret/selfManagedSSM is added in order to allow the license key not be leaked in the environment variables of the lambda function.

i'd be more than happy to propose a PR.

@workato-integration
Copy link

@larivierec
Copy link
Author

any update on this ticket?

@chaudharysaket
Copy link
Contributor

Thank you for the suggestion. We will take this task in the coming week, due to some other tasks already planned ahead. In the meantime, if you get some time and want to assist with a proposed PR, we would welcome it. Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants