Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tag property to newrelic resources that support tags #1420

Closed
favandemeer opened this issue Aug 18, 2021 · 6 comments
Closed

Add tag property to newrelic resources that support tags #1420

favandemeer opened this issue Aug 18, 2021 · 6 comments
Labels
enhancement New feature or request group-general

Comments

@favandemeer
Copy link

Feature Description

Add a tags property to the newrelic terraform resources so we can set that on creation already.

Describe Alternatives

The way it works now is very uncomfortable, as you have to create the resource, await it being created, scrape the data source again to find its id and then use the newrelic_entity_tags resource to add tags.

Additional context

It would be great if we could add tags as a property in all resources in the newrelic provider that support tags.

@rdhar
Copy link

rdhar commented Aug 25, 2021

This would bring it line with existing behaviour of other popular Terraform providers—such as AWS—wherein resources can be natively tagged on creation.

In our monitoring estate, I can see this leading to wider adoption of workloads as well since we could better filter on tagged entities to render what's important. Thanks.

@MAN98
Copy link

MAN98 commented Sep 2, 2021

I believe this is related to this issue #756

@stale
Copy link

stale bot commented Sep 17, 2021

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Sep 17, 2021
@stale
Copy link

stale bot commented Sep 24, 2021

This issue has been automatically closed due to a lack of activity for an extended period of time.

@stale stale bot closed this as completed Sep 24, 2021
@kidk kidk reopened this Oct 7, 2021
@kidk kidk added group-general and removed stale labels Oct 7, 2021
@zeffron
Copy link
Contributor

zeffron commented Jan 6, 2022

For us, this is related to #756 in that the synthetics are what we'd like to be able to tag. However, I don't believe this should depend on #756. It should be entirely possible to add a tags section to entities supporting tags and have the provider wait for the GUID to become available (if the resource is being created and a wait is necessary) regardless of which API is being used in the backend (REST or NerdGraph).

@kidk kidk added the enhancement New feature or request label Mar 9, 2022
@kidk kidk added this to the Synthetics GraphQL milestone Mar 9, 2022
@kidk
Copy link
Contributor

kidk commented Aug 29, 2022

Support for tags has been added to the new Synthetics resources: https://registry.terraform.io/providers/newrelic/newrelic/latest/docs/guides/migration_guide_v3

As it is unlikely other API's will start supporting tags through their create/update mutations I'm going to close this ticket. As almost every resource now returns a GUID it should be possible to use the https://registry.terraform.io/providers/newrelic/newrelic/latest/docs/resources/entity_tags resource.

If you encounter any API delays that stop you from using the entity_tags or requiring multiple terraform runs, please create a ticket so we can improve those cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request group-general
Projects
None yet
Development

No branches or pull requests

5 participants