Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data_source_newrelic_notifications_destination): Support name in destination data source #2395

Merged
merged 10 commits into from
Jun 15, 2023

Conversation

lzaga-newrelic
Copy link
Collaborator

@lzaga-newrelic lzaga-newrelic commented Jun 11, 2023

Description

Add support for creating destination data sources by name. Jira ticket link here.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

Please delete options that are not relevant.

  • My commit message follows conventional commits
  • My code is formatted to Go standards
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes. Go here for instructions on running tests locally.

How to test this change?

Please describe how to test your changes. Include any relevant steps in the UI, HCL file(s), commands, etc

  • Create a destination with a specific name via New Relic notifications destination UI - in the Alerts tab
  • Add this code to your terraform file with the name of the destination:
data "newrelic_notification_destination" "foo" {
  name = <destination_name>
}

@lzaga-newrelic lzaga-newrelic self-assigned this Jun 11, 2023
@lzaga-newrelic
Copy link
Collaborator Author

Waiting for this PR: newrelic/newrelic-client-go#1014

@lzaga-newrelic lzaga-newrelic marked this pull request as ready for review June 14, 2023 14:23
@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2023

Codecov Report

Merging #2395 (c5d32a9) into main (8ec7a5b) will decrease coverage by 0.01%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main    #2395      +/-   ##
==========================================
- Coverage   33.96%   33.95%   -0.01%     
==========================================
  Files          91       91              
  Lines       24760    24773      +13     
==========================================
+ Hits         8409     8411       +2     
- Misses      16199    16210      +11     
  Partials      152      152              
Impacted Files Coverage Δ
.../data_source_newrelic_notifications_destination.go 53.57% <40.00%> (-7.00%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pranav-new-relic pranav-new-relic merged commit cffec97 into newrelic:main Jun 15, 2023
9 checks passed
@lzaga-newrelic lzaga-newrelic deleted the add-destination-ds-name branch June 18, 2023 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants