Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbolic link not working on Windows #307

Closed
peterleif opened this issue Dec 4, 2021 · 2 comments
Closed

Symbolic link not working on Windows #307

peterleif opened this issue Dec 4, 2021 · 2 comments

Comments

@peterleif
Copy link

These 2 files are commited as symbolic links

However, these symbolic links are not treated as symbolic links on Windows (they are substituted by text files instead).

Could you consider stop commiting these files as symbolic links?

Thanks

@CervEdin
Copy link

CervEdin commented Jan 3, 2022

you can enable symlinks in windows

@newren
Copy link
Owner

newren commented Jun 4, 2022

If I make them be copies of the file in question, then I have to update them both whenever I update the main file. That makes history rather ugly. If you don't want to enable symlinks on Windows, just make them be copies yourself and they'll function just fine.

Additional Background

I would have preferred to not have git_filter_repo.py exist at all, but python made importing files that don't end in .py really painful and makes all the contrib examples super ugly (and also files that use hyphens rather than underscores). I also couldn't just use git-filter-repo.py because git X calls git-X; not git-X.py. So, I need both to exist, but I don't want to update both. Symlinks are a super nice solution, but others can switch it to a copy locally if they want.

filter-branch-ish only exists so that people can find "filter-branch" and how to replace it. The real name of the script is "filter-lamely" because filter-branch has a horrendous design that is going to cause people problems and I want the name of the script to warn people against its use. They symlink also makes it clear that the file has a real name elsewhere.

So, both serve good purposes, and I'll keep both as symlinks. You can turn them into copies on your end if you please; nothing relies on them remaining symlinks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants