-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
Codecov Report
@@ Coverage Diff @@
## master #144 +/- ##
==========================================
+ Coverage 51.76% 51.82% +0.05%
==========================================
Files 107 107
Lines 1418 1428 +10
Branches 355 358 +3
==========================================
+ Hits 734 740 +6
- Misses 607 611 +4
Partials 77 77
|
blocked on NewSpring/crete#95 |
@redreceipt This is no longer blocked. Should be good to go. |
onClose={() => this.closePrayer()} | ||
title={"Celebrate God's faithfulness"} | ||
prayerId={this.prayerId} | ||
prayerText={this.props.navigation.getParam( | ||
'prayerText', | ||
'' | ||
)} | ||
prayerAnswer={this.prayerAnswer} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason you're defining some of these as separate functions and variables?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I did that because I use prayerId
and prayerAnswer
a little further down. So instead of calling the getParam
function again I just made one function for each of them that would set it.
Co-authored-by: Michael Neeley <micneeley14@gmail.com>
Co-authored-by: Michael Neeley <micneeley14@gmail.com>
@redreceipt Okay so I made everything use |
Yea you're right it does. What about defining:
and then using the prayer object everywhere:
|
Yeah ... actually that's much, much better. |
id: this.props.navigation.getParam('prayerId', ''), | ||
text: this.props.navigation.getParam('prayerText', ''), | ||
answer: this.props.navigation.getParam('prayerAnswer', ''), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couldn't we pass these in as one combined nav param?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what you mean.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prayer = this.props.navigation.getParam('prayer', {id: "", text: "", answer: ""})
DESCRIPTION
What does this PR do, or why is it needed?
This PR adds the ability to remove an answer to a prayer.
How do I test this PR?
My Prayers
TODO
REVIEW
Manual QA