Skip to content
This repository has been archived by the owner on Feb 13, 2023. It is now read-only.

fix: Fixes saving inconsistencies #21

Merged
merged 1 commit into from
Jan 14, 2020
Merged

fix: Fixes saving inconsistencies #21

merged 1 commit into from
Jan 14, 2020

Conversation

redreceipt
Copy link
Contributor

@redreceipt redreceipt commented Jan 13, 2020

DESCRIPTION

Screen Shot 2020-01-13 at 3 44 21 PM

What does this PR do, or why is it needed?

This adds a necessary field in the queries for the save button to work properly.

How do I test this PR?

Play around with saving and unsaving prayers. Make sure it's consistent and nothing looks out of place.

TODO

  • I am affirming this is my best work (Ecclesiastes 9:10)
  • PR has a relevant title that will be understandable in a public changelog (ie...non developers)
  • No new warnings
  • Upload GIF(s) of iOS and Android if applicable
  • Set a relevant reviewer

REVIEW

  • Review updates to test coverage and snapshots
  • Review code through the lens of being concise, simple, and well-documented

Manual QA

  • Manual QA on iOS and ensure it looks/behaves as expected
  • Manual QA on Android and ensure it looks/behaves as expected

The purpose of PR Review is to improve the quality of the software.

@redreceipt redreceipt added the ready for review This one is ready to review label Jan 13, 2020
@codecov
Copy link

codecov bot commented Jan 13, 2020

Codecov Report

Merging #21 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #21   +/-   ##
========================================
  Coverage    56.79%   56.79%           
========================================
  Files          133      133           
  Lines         1243     1243           
  Branches       135      135           
========================================
  Hits           706      706           
  Misses         462      462           
  Partials        75       75

Copy link
Member

@richarddubay richarddubay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it's working. 👍

@richarddubay richarddubay added merge When the tests pass, merge! and removed ready for review This one is ready to review labels Jan 14, 2020
@richarddubay richarddubay merged commit f12949f into develop Jan 14, 2020
@richarddubay richarddubay deleted the fixes-saving branch January 14, 2020 15:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
merge When the tests pass, merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants