This repository has been archived by the owner on Feb 13, 2023. It is now read-only.
chore: Fixes feed cards #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is very clever. if they don't like mine, this works perfectly |
Codecov Report
@@ Coverage Diff @@
## upgrade-1.3.0 #42 +/- ##
=============================================
Coverage 54.1% 54.1%
=============================================
Files 110 110
Lines 1048 1048
Branches 121 121
=============================================
Hits 567 567
Misses 409 409
Partials 72 72 |
richarddubay
added
ready for review
redreceipt
approved these changes
Feb 4, 2020
mergify bot
added a commit
that referenced
this pull request
Feb 4, 2020
* conflicts * conflicts and linter errors * adds polyfill file * put live button baack * fixes live button * fixed some tests * snaps * stripped off Newspring from labels * Get the search feed working * Schema changes * Fix SearchFeed tests * hides nav bar in browser * changes testing link * Updated theme to include 'ui' font-family and updated tests * Okay, used the right font-family this time * Fixed the discover feed tests - mocking data is hard * fixes sermon content * new lockfiles * chore: Fixes feed cards (#42) * Fix the search and home feeds so the cards display correctly. * Added a bit more data so that we could get the pill to be correct * Show the right card type based on type and add the label text correctly. * Made sure we were using the right id * Updated snapshots * Get the data the right way * Fixes discover feed tiles * updated lock files Co-authored-by: Michael Neeley <micneeley14@gmail.com> Co-authored-by: Richard Dubay <richardtdubayjr@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION
What does this PR do, or why is it needed?
This PR fixes the home and search feeds so the cards display correctly.
I PR'd this to the
upgrade-1.3.0branch (instead of just pushing) because I wanted it to be looked over before it was merged in. I know we're doing some other work with cards that could potentially make this whole thing moot, but I wanted to fix it if I could just in case that took a while.How do I test this PR?
Make sure the feeds look like they did before we upgraded.
TODO
REVIEW
Manual QA