Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to react-native 0.49 and react 16 #266

Merged
merged 35 commits into from
Oct 12, 2017
Merged

Conversation

a-ursino
Copy link
Contributor

@a-ursino a-ursino commented Oct 3, 2017

EDIT 1: update to react-native 0.48.4 and react-native-web 0.1.0
EDIT 2: update to react-native 0.49.0 and react-native-web 0.1.3
EDIT 3: update to react-native 0.49.3 and react-native-web 0.1.7

Updated deps

  • react-native: 0.42.3 -> 0.49.3
  • react: 15.4.2 -> 16.0.0
  • react-dom 15.4.2 -> 16.0.0
  • react-native-web 0.0.119 -> 0.1.7
  • react-test-renderer 15.4.2 -> 16.0.0
  • react-native-storybook-loader: 1.4.1 -> 1.5.1
  • prop-types 15.5.10 -> 15.6.0
  • jest 20.0.4 -> 21.2.1
  • enzyme 2.9.1 -> 3.1.0 Migration Guide for enzyme v2.x to v3.x
  • enzyme-adapter-react 16 1.0.1 (NEW)
  • enzyme-to-json 1.5.1 -> 3.1.0
  • react-addons-test-utils (REMOVED) -> react-dom/test-utils
  • svg 2.3.0 -> 3.1.0
  • react-native-svg 5.1.7 -> 5.4.1

iOS

  • new native library libRCTBlob added (in v0.48.0)
  • move scripts from packager to scripts folder

Enzyme
With Enzyme 3:

  • new Adapter system to deal with different versions of React and other frameworks (Preact, Inferno..)
  • new format for the snapshot

React Addons Test Utils
No more react-addons-test-utils lib, use instead react-dom/test-utils

Jest
Jest v21 snapshots handle whitespace differently

Warning
Using <Image>with children is deprecated
<ListView> is deprecated

Master branch
Done in 138.95s.
real 2m19.261s
user 5m6.292s
sys 0m17.313s

This branch
Done in 274.23s.
real 4m34.540s
user 5m1.409s
sys 2m1.216s

@a-ursino a-ursino changed the title Feat/update to react-native 0.48 and react 16 [WIP] Feat/update to react-native 0.48 and react 16 Oct 3, 2017
@sericaia
Copy link
Contributor

sericaia commented Oct 3, 2017

This code is fine and fixes the android issue 👍
image

The only issue that still remains is this one necolas/react-native-web#669

@a-ursino a-ursino changed the title [WIP] Feat/update to react-native 0.48 and react 16 Update to react-native 0.48 and react 16 Oct 4, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+1.3%) to 97.872% when pulling c510c87 on feat/update-react-048 into 402244b on master.

@rjanjua
Copy link
Contributor

rjanjua commented Oct 4, 2017

the bitrise job is failing because it seems detox is not ready for React 16 - the failure is not genuine. We need to check that everything works in storybook and storybook-native

@a-ursino a-ursino changed the title Update to react-native 0.48 and react 16 Update to react-native 0.49 and react 16 Oct 4, 2017
@aronshamash
Copy link
Contributor

I have checked through web, ios and android and the component functionality has not regressed as far as I can see.

@sericaia
Copy link
Contributor

sericaia commented Oct 4, 2017

In order to fix the android issue

* What went wrong:
Execution failed for task ':app:transformDexArchiveWithExternalLibsDexMergerForDebug'.
> java.lang.RuntimeException: java.lang.RuntimeException: com.android.builder.dexing.DexArchiveMergerException: Unable to merge dex

I deleted android/.gradle folder and after running yarn android it was generated again and everything worked fine

@coveralls
Copy link

Coverage Status

Coverage increased (+1.1%) to 97.872% when pulling 3fc30dd on feat/update-react-048 into baf389f on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.1%) to 97.872% when pulling 0c507a9 on feat/update-react-048 into baf389f on master.

@a-ursino
Copy link
Contributor Author

a-ursino commented Oct 5, 2017

seems like we need to wait for this issue to be closed wix/Detox#279

@coveralls
Copy link

Coverage Status

Coverage increased (+1.3%) to 97.959% when pulling fbb2437 on feat/update-react-048 into d48010f on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.3%) to 97.959% when pulling 47a7f1b on feat/update-react-048 into d48010f on master.

@sericaia
Copy link
Contributor

Getting this now:
image

@JGAntunes
Copy link
Contributor

Tested it in web (chrome and IE11) and Android and spotted no regressions 👍

@coveralls
Copy link

Coverage Status

Coverage increased (+1.3%) to 97.959% when pulling 0bcb2fb on feat/update-react-048 into b48f451 on master.

@coveralls
Copy link

coveralls commented Oct 12, 2017

Coverage Status

Coverage increased (+1.3%) to 97.872% when pulling c510c87 on feat/update-react-048 into 402244b on master.

@craigbilner craigbilner merged commit 760e111 into master Oct 12, 2017
@craigbilner craigbilner deleted the feat/update-react-048 branch October 12, 2017 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants