-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to react-native 0.49 and react 16 #266
Conversation
This code is fine and fixes the android issue 👍 The only issue that still remains is this one necolas/react-native-web#669 |
the bitrise job is failing because it seems detox is not ready for React 16 - the failure is not genuine. We need to check that everything works in storybook and storybook-native |
I have checked through web, ios and android and the component functionality has not regressed as far as I can see. |
In order to fix the android issue
I deleted |
seems like we need to wait for this issue to be closed wix/Detox#279 |
Tested it in web (chrome and IE11) and Android and spotted no regressions 👍 |
EDIT 1: update to react-native 0.48.4 and react-native-web 0.1.0
EDIT 2: update to react-native 0.49.0 and react-native-web 0.1.3
EDIT 3: update to react-native 0.49.3 and react-native-web 0.1.7
Updated deps
iOS
libRCTBlob
added (in v0.48.0)Enzyme
With Enzyme 3:
React Addons Test Utils
No more
react-addons-test-utils
lib, use insteadreact-dom/test-utils
Jest
Jest v21 snapshots handle whitespace differently
Warning
Using
<Image>
with children is deprecated<ListView>
is deprecatedMaster branch
Done in 138.95s.
real 2m19.261s
user 5m6.292s
sys 0m17.313s
This branch
Done in 274.23s.
real 4m34.540s
user 5m1.409s
sys 2m1.216s