Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hope to integrate WaveDrom like mermaid #536

Closed
POMIN-163 opened this issue Jun 24, 2022 · 7 comments · Fixed by #655
Closed

Hope to integrate WaveDrom like mermaid #536

POMIN-163 opened this issue Jun 24, 2022 · 7 comments · Fixed by #655
Labels
Feature Request New feature or request Solved
Milestone

Comments

@POMIN-163
Copy link

Hope to integrate WaveDrom like mermaid.

when i installed next theme, i can use this to render a pie chart.

{% mermaid pie %}
"Dogs" : 386
"Cats" : 85
"Rats" : 15
{% endmermaid %}

Similarly, WaveDrom can render the wavejson to a wave picture, use https://svg.wavedrom.com to generate a svg.

such as this:

<img src="https://svg.wavedrom.com/{signal:[{name:'clk',wave:'p......'},{name:'bus',wave:'x.34.5x',data:'head body tail'},{name:'wire',wave:'0.1..0.'}]}"/>

preview:

the WaveDrom site: https://github.com/wavedrom/wavedrom
I sincerely invite you to try it. It's so amazing.

@POMIN-163 POMIN-163 added the Feature Request New feature or request label Jun 24, 2022
@welcome
Copy link

welcome bot commented Jun 24, 2022

Thanks for opening this issue, maintainers will get back to you as soon as possible!

@stevenjoezhang
Copy link
Member

You can simply use markdown image tag, e.g.

![](https://svg.wavedrom.com/...)

@r12f
Copy link
Contributor

r12f commented May 19, 2023

I have worked on this issue and made it work, since it makes using wavedrom much easier as well as avoiding sending request to the rendering server (long payload can cause failure and has other problems). @stevenjoezhang, do you mind to help see if this makes sense? If so, I can help make more changes to doc and the plugin repo and send out the PRs.

r12f@476811b

@r12f
Copy link
Contributor

r12f commented May 19, 2023

I cannot reactivate this issue, so please let me know, if a new issue is preferred for discussion

@stevenjoezhang
Copy link
Member

@r12f pull requests are welcomed 🤩

@r12f
Copy link
Contributor

r12f commented May 19, 2023

awesome! I have made these 3 PRs here:

First time making the PR, so might miss things. Please let me know, if anything needs to be changed!

Also, please let me know how to activate this issue, or we prefer to open a new one. Will be more than happy to do it.

@stevenjoezhang stevenjoezhang added this to the 8.17.0 milestone May 23, 2023
@stevenjoezhang stevenjoezhang linked a pull request May 23, 2023 that will close this issue
11 tasks
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. It is possible issue was solved or at least outdated. Feel free to open new for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Feature Request New feature or request Solved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants