Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename show and menu class names in menu element that are likely to collide with styles that are already in use. #68

Open
ouromoros opened this issue Sep 24, 2021 · 0 comments

Comments

@ouromoros
Copy link

Hi, I'm myself a front-end noobie and I came into this problem today.

The problem is that my website already has css styles for class show and menu, which caused the related spotlight UIs (the navigate menu) to behave in an odd way.

Today it took me a lot of time to track down this problem. I ended up having to use css-selectors like #spotlight.menu to explicitly disable the errorneous styles in order to get the UIs working.

I think we'd better use class names like spotlight-show instead of show to avoid accidents like this. Since spotlight aims to be the most easy to integrate js gallery, it's important to avoid this kind of unintended behavior that would surprise users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant