Session with all null values on user with jwt, how does it work ? #683

Mautriz · 2020-09-17T18:55:03Z

Your question
I'm using JWT, the object return by useSession is always empty (it exists, but with all null values on the user object ex: { name: null, email: null, picture: null } even tho the debug logs everything correctly.

What are you trying to do
I customized the callbacks to return the user, I expected it to this by default, it took me a while to realize how to to it

this is my code

import NextAuth, { InitOptions } from 'next-auth'
import Adapters from 'next-auth/adapters'
import Providers from 'next-auth/providers'
import { prismaClient } from '../../../../graphql/configs/prismaClient'

const options: any = {
  providers: [
    Providers.Facebook({
      clientId: process.env.FACEBOOK_CLIENT_ID,
      clientSecret: process.env.FACEBOOK_CLIENT_SECRET,
    }),
  ],
  database: process.env.DATABASE_URL,
  jwt: {
    encryption: true,
    // secret: process.env.AUTH_SECRET,
  },
  session: {
    jwt: true,
    updateAge: 1000 * 60 * 60 * 24,
  },
  secret: process.env.AUTH_SECRET,
  useSecureCookies: process.env.NODE_ENV === 'production',
  adapter: Adapters.Prisma.Adapter({ prisma: prismaClient }),
  debug: true,
 // these callbacks are what makes the user work as expected, otherwise it returns empty values
  callbacks: {
    session(session, payload) {
      if (payload.account) session.user = payload.account
      return session
    },
    jwt(token, account, user, userInfo) {
      if (userInfo) token.account = userInfo
      return token
    },
  },
}

export default (req, res) => {
  return NextAuth(req, res, options)
}

// _app.tsx
 <Provider session={pageProps.session} options={{ keepAlive: TEN_MINUTES, clientMaxAge: ONE_WEEK }}>
        <Component {...pageProps} />
   </Provider>

// index.tsx

function Home() {
  const { data, loading: queryLoading } = useMyQueryQuery({ ssr: true, fetchPolicy: 'cache-first' })
  const [session, sessionLoading] = useSession()
  return (
    <Layout>
      <Head>
        <title>Next.js × Nexus Todo App</title>
      </Head>
      {session && JSON.stringify(session)}
      {sessionLoading}
      <a href="/api/auth/signin">Sign in</a>
      <a href="/api/auth/signout">Sign out</a>
    </Layout>
  )
}

Feedback

[-] Found the documentation helpful // meh, kinda, the callbacks doc surely helped, but took me a while to realize I had to use them
Found documentation but was incomplete
[] Could not find relevant documentation
[] Found the example project helpful
Did not find the example project helpful // it didnt have callbacks, but worked fine appearently

Seems like a great library btw ! :D, I probably just misunderstood something I suppose

iaincollins · 2020-09-22T13:52:59Z

Hi @Mautriz

Thanks for sharing your issue and config!

This should actually work out of the box for name, email and picture, as per the example:

https://next-auth-example.now.sh/api-example

I wonder what the trigger is for this issue.

stale · 2020-12-05T12:16:14Z

Hi there! It looks like this issue hasn't had any activity for a while. It will be closed if no further activity occurs. If you think your issue is still relevant, feel free to comment on it to keep ot open. Thanks!

stale · 2020-12-12T12:46:13Z

Hi there! It looks like this issue hasn't had any activity for a while. To keep things tidy, I am going to close this issue for now. If you think your issue is still relevant, just leave a comment and I will reopen it. (Read more at #912) Thanks!

ChristoRibeiro · 2020-12-18T11:07:31Z

@iaincollins I get the same issue and seems to be related with Prisma adapter. If I remove the adapter, everything works great without callback.

ChristoRibeiro · 2020-12-18T16:25:15Z

Here some tests with no user in database (pg) and no user in my Github App.

Test 1

JWT + Prisma:

 providers: [
    Providers.GitHub({
      clientId: process.env.GITHUB_ID,
      clientSecret: process.env.GITHUB_SECRET,
    }),
  ],
  secret: process.env.SECRET,
  // database: process.env.DATABASE_URL,
  adapter: Adapters.Prisma.Adapter({ prisma }),
  session: {
    jwt: true,
  },

Results:

1st signIn → Success: Session has data. JWT no data.
2nd signIn → Failure: Session has no data. JWT has no data.

Test 2

Session + Prisma

  // database: process.env.DATABASE_URL,
  adapter: Adapters.Prisma.Adapter({ prisma }),
  // session: {
  //  jwt: true,
  // },

Result: Success → Session has data.

Test 3

JWT + Typeorm:

   database: process.env.DATABASE_URL,
  // adapter: Adapters.Prisma.Adapter({ prisma }),
  session: {
    jwt: true,
  },

Result: Success → Session has data.

Conclusion

So JWT + Prisma AND isNewUser == false the token has no data. Any idea @iaincollins of why?

ChristoRibeiro · 2020-12-18T23:00:27Z

I found the error.

The function getUserByProviderAccountId from the Prisma adapter return a row from the Account table instead of the User table. So here the user variable do not contains the right data and the JWT payload can't be filled correctly.

Is it possible to have a v3.1.1 that fix this issue?

Cc @iaincollins & @balazsorban44.

ChristoRibeiro · 2020-12-19T09:35:56Z

in the Prisma adapter, this should fix the issue:

- return prisma[Account].findOne({ where: { compoundId: getCompoundId(providerId, providerAccountId) } })
+ const account = await prisma[Account].findOne({ where: { compoundId: getCompoundId(providerId, providerAccountId) } })
+ if (!account) { return null }
+ return prisma[User].findOne({ where: { id: account.userId } })

balazsorban44 · 2020-12-19T12:35:49Z

Hi, @ChristoRibeiro could you please create a PR with your recommended fix so it's easier to evaluate? Thank you!

ChristoRibeiro · 2020-12-19T15:07:13Z

The issue doesn't appear anymore on the canary branch and the deprecated prisma method findOne has been updated to findUnique. I'm not sur a PR is required. Do you plan to make a release soon @balazsorban44?

balazsorban44 · 2020-12-19T15:08:08Z

Yes, hopefully this month.

balazsorban44 · 2021-01-21T21:21:42Z

Canary has been out for a while now, try it out with npm i next-auth@canary 🎉

lommaj · 2021-02-24T04:41:00Z

Are we sure this is working? I am not sure if its just me but I cant seem to get JWT to work with prisma adapter, using canary.

balazsorban44 · 2021-02-24T08:59:52Z

@lommaj please open a new issue or a discussion with a reproduction of your problem. I would also recommend updating to latest (which is 3.5.1 as of this writing) as. several things have been addressed

Mautriz added the question Ask how to do something or how something works label Sep 17, 2020

iaincollins added the help-needed The maintainer needs help due to time constraint/missing knowledge label Sep 22, 2020

stale bot added the stale Did not receive any activity for 60 days label Dec 5, 2020

stale bot closed this as completed Dec 12, 2020

balazsorban44 reopened this Dec 18, 2020

stale bot removed the stale Did not receive any activity for 60 days label Dec 18, 2020

balazsorban44 closed this as completed Jan 21, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Session with all null values on user with jwt, how does it work ? #683

Session with all null values on user with jwt, how does it work ? #683

Mautriz commented Sep 17, 2020 •

edited

Loading

iaincollins commented Sep 22, 2020

stale bot commented Dec 5, 2020

stale bot commented Dec 12, 2020

ChristoRibeiro commented Dec 18, 2020 •

edited

Loading

ChristoRibeiro commented Dec 18, 2020 •

edited

Loading

ChristoRibeiro commented Dec 18, 2020 •

edited

Loading

ChristoRibeiro commented Dec 19, 2020 •

edited

Loading

balazsorban44 commented Dec 19, 2020 •

edited

Loading

ChristoRibeiro commented Dec 19, 2020

balazsorban44 commented Dec 19, 2020

balazsorban44 commented Jan 21, 2021

lommaj commented Feb 24, 2021

balazsorban44 commented Feb 24, 2021 •

edited

Loading

Session with all null values on user with jwt, how does it work ? #683

Session with all null values on user with jwt, how does it work ? #683

Comments

Mautriz commented Sep 17, 2020 • edited Loading

iaincollins commented Sep 22, 2020

stale bot commented Dec 5, 2020

stale bot commented Dec 12, 2020

ChristoRibeiro commented Dec 18, 2020 • edited Loading

ChristoRibeiro commented Dec 18, 2020 • edited Loading

Test 1

Test 2

Test 3

Conclusion

ChristoRibeiro commented Dec 18, 2020 • edited Loading

ChristoRibeiro commented Dec 19, 2020 • edited Loading

balazsorban44 commented Dec 19, 2020 • edited Loading

ChristoRibeiro commented Dec 19, 2020

balazsorban44 commented Dec 19, 2020

balazsorban44 commented Jan 21, 2021

lommaj commented Feb 24, 2021

balazsorban44 commented Feb 24, 2021 • edited Loading

Mautriz commented Sep 17, 2020 •

edited

Loading

ChristoRibeiro commented Dec 18, 2020 •

edited

Loading

ChristoRibeiro commented Dec 18, 2020 •

edited

Loading

ChristoRibeiro commented Dec 18, 2020 •

edited

Loading

ChristoRibeiro commented Dec 19, 2020 •

edited

Loading

balazsorban44 commented Dec 19, 2020 •

edited

Loading

balazsorban44 commented Feb 24, 2021 •

edited

Loading