Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop MimeType.getIconUrl #943

Closed
skjnldsv opened this issue Aug 24, 2023 · 2 comments · Fixed by #962
Closed

Drop MimeType.getIconUrl #943

skjnldsv opened this issue Aug 24, 2023 · 2 comments · Fixed by #962

Comments

@skjnldsv
Copy link
Contributor

skjnldsv commented Aug 24, 2023 •
edited
Loading

On 28, we'll deprecate that front API and sugges to use the preView controller new redirect to mime instead

Refs:
@susnux
Copy link
Contributor

susnux commented Aug 26, 2023

Do you think it makes sense to provide the URL with the files library?
either some getPreviewURL(node: Node) function or as a method of the Node class?

@susnux
Copy link
Contributor

susnux commented Aug 26, 2023

Or is there some documentation of this API?

@susnux susnux mentioned this issue Aug 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@susnux @skjnldsv