-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add whiteboard container for nc30 #5063
Comments
Relevant occ commands to automate configuration are in the apps readme, caddy config can be adapted from https://socket.io/docs/v3/reverse-proxy/#caddy-2 |
|
|
All good, thanks! I will be working on that for the next major release of AIO that will be shipping nc30 for everyone. It will likely come out when nc30.0.1 or nc30.0.2 is released. |
@juliushaertl looks like the package is private or not reachable for me? |
Changed the visibility, can you check that one? |
yes, can see it 👍 |
# syntax=docker/dockerfile:latest
FROM node:20.17.0-alpine3.20
SHELL ["/bin/ash", "-eo", "pipefail", "-c"]
ENV NODE_ENV=production
ARG WB_VER=v1.0.0-rc.1
WORKDIR /app
RUN apk upgrade --no-cache -a && \
apk add --no-cache ca-certificates tzdata netcat-openbsd && \
wget https://github.com/nextcloud-releases/whiteboard/archive/refs/tags/"$WB_VER".tar.gz -O - | tar xzC /app --strip-components=1 && \
npm install --global clean-modules && \
npm clean-install && \
npm cache clean --force && \
clean-modules --yes && \
npm uninstall --global clean-modules && \
chown -R nobody:nobody /app
USER nobody
ENTRYPOINT ["npm", "run", "server:start"]
HEALTHCHECK CMD nc -z 127.0.0.1 3002 || exit 1 should work (Dockerlint should be ok, it is just one run step) - workflow needed vor version updates |
Thanks @Zoey2936 but my idea was rather to re-use the existing container... WDYT? |
also possible, but then the upstream Dockerfile needs changes:
|
@juliushaertl FYI ⬆️ |
Í can also open a PR at https://github.com/nextcloud/whiteboard |
Sounds good, thanks for the offer :) |
Definitely, a pr there is much appreciated |
Merged and released as 1.0.0-rc.2, thanks again @Zoey2936 |
@juliushaertl I am wondering if we should rather wait for nextcloud/whiteboard#119 and not implement the container additionally in AIO as the app_api is already part of AIO. |
However users of https://github.com/nextcloud/all-in-one/tree/main/nextcloud-aio-helm-chart would then not be able to easily run it... |
For now nextcloud/whiteboard#119 will have performance penalty as there is only a way to proxy requests through a PHP endpoint, so at least in the first iteration there is no websocket connection just polling. I think running the separate container is still the better approach. |
All right. Will add it then to aio directly 👍 |
This is now released with v9.6.0 Beta. Testing and feedback is welcome! See https://github.com/nextcloud/all-in-one#how-to-switch-the-channel |
As option to the aio interface. See nextcloud/whiteboard#82 and #378 as reference
FYI @juliushaertl
The text was updated successfully, but these errors were encountered: